Jackie-Jiang commented on code in PR #12969:
URL: https://github.com/apache/pinot/pull/12969#discussion_r1571768404
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/PinotReflectionUtils.java:
##########
@@ -48,6 +48,7 @@ public static Set<Class<?>>
getClassesThroughReflection(String regexPattern, Cla
return getClassesThroughReflection(PINOT_PACKAGE_NAME, regexPattern,
annotation);
}
+ @SuppressWarnings("deprecation")
Review Comment:
Are the changes in this file related?
##########
pinot-spi/pom.xml:
##########
@@ -33,6 +33,7 @@
<url>https://pinot.apache.org/</url>
<properties>
<pinot.root>${basedir}/..</pinot.root>
+ <shade.phase.prop>package</shade.phase.prop>
Review Comment:
Seems it is not enabled by default. Do you enable it by explicitly setting
the flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
