Jackie-Jiang commented on code in PR #12969: URL: https://github.com/apache/pinot/pull/12969#discussion_r1572674694
########## pinot-spi/pom.xml: ########## @@ -33,6 +33,7 @@ <url>https://pinot.apache.org/</url> <properties> <pinot.root>${basedir}/..</pinot.root> + <shade.phase.prop>package</shade.phase.prop> Review Comment: In that case, should we try to keep the same behavior? With the change in this PR it will always be shaded, which is a behavior change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
