shounakmk219 commented on code in PR #12856: URL: https://github.com/apache/pinot/pull/12856#discussion_r1558915239
########## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml: ########## @@ -1,173 +1,173 @@ rules: -- pattern: "\"org.apache.pinot.common.metrics\"<type=\"BrokerMetrics\", name=\"pinot.broker.(([^\\.]+)\\.)?([^\\.]*?).authorization\"><>(\\w+)" +- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^\\.]+)\\.)?([^\\.]*)\\.authorization\"><>(\\w+)" Review Comment: Just validated both metrics with `[^\\.]` and `[^.]`, you are right both are equivalent. Will make that update too. Regarding the documentation for the prometheus config here is a [link](https://github.com/prometheus/jmx_exporter/tree/release-0.20.0?tab=readme-ov-file#configuration) I referred. According to the doc, only `pattern` field takes a regex while capture groups from pattern can be used in labels. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
