Jackie-Jiang commented on code in PR #12856: URL: https://github.com/apache/pinot/pull/12856#discussion_r1558089252
########## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml: ########## @@ -1,173 +1,173 @@ rules: -- pattern: "\"org.apache.pinot.common.metrics\"<type=\"BrokerMetrics\", name=\"pinot.broker.(([^\\.]+)\\.)?([^\\.]*?).authorization\"><>(\\w+)" +- pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(([^\\.]+)\\.)?([^\\.]*)\\.authorization\"><>(\\w+)" Review Comment: Does this follow java regex? If so `[^\\.]` should be equivalent to `[^.]` Can you share the documentation for the prometheus config? Do all fields take regex as input? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
