shounakmk219 opened a new pull request, #12856:
URL: https://github.com/apache/pinot/pull/12856

   # Description
   The `.` requires escaping throughout the pattern string if it is intended to 
represent a `.` literal. The only reason its working right now is because its 
surrounded by specific patterns, so the match all `.` regex is only matching 
actual `.` character.
   More discussion around this issue (with an example where it breaks) 
[here](https://github.com/apache/pinot/pull/12739#discussion_r1552865521).
   
   This PR tries to fix this by escaping all `.` literals.
   It also replaces `*?` with `*` for custom metric rules as the surrounding 
pattern matching is well defined.
   
   # labels
   `bugfix` `refactor`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to