marregui commented on PR #12668: URL: https://github.com/apache/pinot/pull/12668#issuecomment-2009186253
> Thanks for the contribution! Can you please take a look at the thread safety issue? It will be good if you can also share some perf numbers since you've added it to the benchmark classes hi, thank you for the very quick review!!. Indeed it is not thread safe, it will be I will add tests for that. Will also run the benchmarks (intel mac from 2015, not sure the numbers will be amazing compared to better hardware). thank you again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
