Jackie-Jiang commented on code in PR #12668: URL: https://github.com/apache/pinot/pull/12668#discussion_r1530997294
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/compression/GZIPCompressor.java: ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.io.compression; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.zip.Deflater; +import org.apache.pinot.segment.spi.compression.ChunkCompressionType; +import org.apache.pinot.segment.spi.compression.ChunkCompressor; + + +/** + * Implementation of {@link ChunkCompressor} using GZIP compression algorithm. + */ +class GZIPCompressor implements ChunkCompressor { + + static final GZIPCompressor INSTANCE = new GZIPCompressor(); + + private final Deflater _compressor; + + private GZIPCompressor() { + _compressor = new Deflater(); + } + + @Override + public int compress(ByteBuffer inUncompressed, ByteBuffer outCompressed) + throws IOException { + _compressor.reset(); Review Comment: Is this thread safe? The same compressor is shared ########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/compression/GZIPCompressor.java: ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.io.compression; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.zip.Deflater; +import org.apache.pinot.segment.spi.compression.ChunkCompressionType; +import org.apache.pinot.segment.spi.compression.ChunkCompressor; + + +/** + * Implementation of {@link ChunkCompressor} using GZIP compression algorithm. + */ +class GZIPCompressor implements ChunkCompressor { Review Comment: (minor) Since this is not acronym, shall we use camel case? Same for decopressor ```suggestion class GzipCompressor implements ChunkCompressor { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
