wirybeaver commented on code in PR #12532:
URL: https://github.com/apache/pinot/pull/12532#discussion_r1533173351
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractIndexTransformFunction.java:
##########
@@ -44,7 +44,7 @@ public class JsonExtractIndexTransformFunction extends
BaseTransformFunction {
private TransformResultMetadata _resultMetadata;
private JsonIndexReader _jsonIndexReader;
private Object _defaultValue;
- private Map<String, RoaringBitmap> _matchingDocsMap;
+ private Map<String, RoaringBitmap> _valueToMatchingFlattenedDocIdsMap;
Review Comment:
I just realized that we should keep both valueToDocId and
valueToFlattenDocId. Using valueToFlattenDocIds would increase the read latency
since it need to iterate the flattenDocId bitmap and create the docId bitmap.
If the return type isSingleValue, init valueToDocId; otherwise, init
valueToFlattenDocIds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
