Jackie-Jiang commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1517432982
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -572,7 +573,7 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
// Decode message
StreamDataDecoderResult decodedRow =
_streamDataDecoder.decode(messagesAndOffsets.getStreamMessage(index));
msgMetadata = messagesAndOffsets.getStreamMessage(index).getMetadata();
- StreamPartitionMsgOffset messageOffset =
messagesAndOffsets.getNextStreamPartitionMsgOffsetAtIndex(index);
+ int messageOffset = messagesAndOffsets.getMessageOffsetAtIndex(index);
Review Comment:
Does this give the accurate offset? Will it cause overflow?
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -305,6 +305,7 @@ public void deleteSegmentFile() {
private final StreamPartitionMsgOffset _latestStreamOffsetAtStartupTime;
private final CompletionMode _segmentCompletionMode;
+ private List<Integer> _filteredMessageOffsets = new ArrayList<>();
Review Comment:
```suggestion
private final List<Integer> _filteredMessageOffsets = new ArrayList<>();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
