walterddr commented on code in PR #12258:
URL: https://github.com/apache/pinot/pull/12258#discussion_r1463832651
##########
pinot-spi/src/main/java/org/apache/pinot/spi/eventlistener/query/PinotBrokerQueryEventListenerFactory.java:
##########
@@ -44,6 +50,8 @@ private PinotBrokerQueryEventListenerFactory() {
public synchronized static void init(PinotConfiguration
eventListenerConfiguration) {
// Initializes BrokerQueryEventListener.
initializeBrokerQueryEventListener(eventListenerConfiguration);
+ // Initializes request headers
+ initializeAllowlistQueryRequestHeaders(eventListenerConfiguration);
Review Comment:
yeah. i thought about that e.g. the RequestContext is extended by
RequestScope --> which is a spi.trace class. which might be weird to use a
config key prefix to event listener. let's think it through.
BTW the impl is fine. just need to list out exactly how they are being
configured and which overrides what
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
