walterddr commented on code in PR #12258:
URL: https://github.com/apache/pinot/pull/12258#discussion_r1453798419
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/DefaultRequestContext.java:
##########
@@ -562,6 +563,16 @@ public void setProcessingExceptions(List<String>
processingExceptions) {
_processingExceptions.addAll(processingExceptions);
}
+ @Override
+ public Map<String, List<String>> getRequestHttpHeaders() {
Review Comment:
hmm. this is a good question. having everything in there is simple. but I
suppose what we really want here is customizable header tracking (similar to
distributed tracing, yes?); where different organizations might have different
ways to keep these in check.
can we create an issue to discuss the scope? sorry to drag this long but
it's better to understand this and get concensus
my understanding is:
1. there are some extra metadata info related to the request we wanted to
track in the query response
2. these metadata info might be easy to identify and aggregate certain query
patterns (such as auth group name; client type; etc)
3. there can be customizable header fields we want to encode but there are
certain ones we want to left out
4. there should be a way, at service startup, to determine
- what fields are expected to be recorded in the RequestContext, and
- what are each fields expected data type (e.g. number/string/etc)
5. retrieval of these RequestContext fields should be generic (Similar to
`Properties`)
thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
