tibrewalpratik17 commented on code in PR #12258:
URL: https://github.com/apache/pinot/pull/12258#discussion_r1463119339
##########
pinot-spi/src/main/java/org/apache/pinot/spi/eventlistener/query/PinotBrokerQueryEventListenerFactory.java:
##########
@@ -44,6 +50,8 @@ private PinotBrokerQueryEventListenerFactory() {
public synchronized static void init(PinotConfiguration
eventListenerConfiguration) {
// Initializes BrokerQueryEventListener.
initializeBrokerQueryEventListener(eventListenerConfiguration);
+ // Initializes request headers
+ initializeAllowlistQueryRequestHeaders(eventListenerConfiguration);
Review Comment:
> however the request header is associated with RequestContext which is
created in PinotClientRequest. --> seems like they shouldn't share the same
configuration prefix? if so we probably should use pinot.broker as prefix
instead of under event listenser?
hmm I am setting these tracked-headers in `RequestHandler` classes rather
than in `PinotClientRequest`. If we want to change the scope to just
`pinot.broker` then does it make sense to init this conf during `BrokerStarter`
rather than event-listener init. That way, we will have to pass it as an
additional param in `RequestHandler` classes too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
