siddharthteotia commented on code in PR #12223:
URL: https://github.com/apache/pinot/pull/12223#discussion_r1462876804
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/DictionaryIndexConfig.java:
##########
@@ -21,29 +21,46 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.common.base.Preconditions;
import java.util.Objects;
import javax.annotation.Nullable;
import org.apache.pinot.spi.config.table.IndexConfig;
+import org.apache.pinot.spi.config.table.Intern;
public class DictionaryIndexConfig extends IndexConfig {
- public static final DictionaryIndexConfig DEFAULT = new
DictionaryIndexConfig(false, false, false);
- public static final DictionaryIndexConfig DISABLED = new
DictionaryIndexConfig(true, false, false);
+ public static final DictionaryIndexConfig DEFAULT = new
DictionaryIndexConfig(false, false, false, Intern.DISABLED);
Review Comment:
Ideally we should not need to change this since NULL via the default
constructor should be interpreted as DISABLED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
