gortiz commented on PR #12223: URL: https://github.com/apache/pinot/pull/12223#issuecomment-1888753113
Approved, but it would be great to add a JMH benchmark. I would expect that in case we have two segments with dictionary enabled and large strings, a query that groups by them should be quite faster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org