aishikbh commented on code in PR #12220:
URL: https://github.com/apache/pinot/pull/12220#discussion_r1452457301
##########
pinot-core/src/test/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFrameworkTest.java:
##########
@@ -581,6 +581,51 @@ public void testMultipleSegments()
rewindRecordReaders(_multipleSegments);
}
+ @Test
Review Comment:
Added all the tests for each of the following cases :
1. default case there is no limit (single recorReader and multiple
recordReader)
2. Single record reader when there is a limit.
3. Multiple record readers when there is a limit.
4. Case where there's a limit and there is a failure to check if the files
are cleaned up.
5. Delegate record readers vs regular record readers (check if we are
closing in the case of regular ones and check if we are not closing in case of
delegate record readers) for both with limit and without limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
