aishikbh commented on code in PR #12220:
URL: https://github.com/apache/pinot/pull/12220#discussion_r1452451909
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java:
##########
@@ -124,14 +124,8 @@ public List<File> process()
try {
return doProcess();
} catch (Exception e) {
- // Cleaning up file managers no matter they are from map phase or reduce
phase. For those from reduce phase, the
- // reducers should have cleaned up the corresponding file managers from
map phase already.
- if (_partitionToFileManagerMap != null) {
- for (GenericRowFileManager fileManager :
_partitionToFileManagerMap.values()) {
- fileManager.cleanUp();
- }
- }
- // Cleaning up output dir as processing has failed.
+ // Cleaning up output dir as processing has failed. file managers left
from map or reduce phase will be cleaned
Review Comment:
added test to verify the clean up of the files using a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
