aishikbh commented on code in PR #12220: URL: https://github.com/apache/pinot/pull/12220#discussion_r1452081838
########## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/RecordReaderFileConfig.java: ########## @@ -34,8 +34,10 @@ public class RecordReaderFileConfig { public final File _dataFile; public final Set<String> _fieldsToRead; public final RecordReaderConfig _recordReaderConfig; + private final boolean _canModifyRecordReader; Review Comment: changed. I have mentioned the closing logic where we close the recordreader in the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org