gortiz commented on PR #11824: URL: https://github.com/apache/pinot/pull/11824#issuecomment-1785350011
> In the write (creation) path, we create the null value vector only when it is enabled. When column level is explicitly disabled, null vector will be disabled even though it is enabled at table level right? That is not correct. There is a special case for null value vector in [SegmentColumnarIndexCreator](https://github.com/apache/pinot/blob/55f29fe04dc7ed0ff18737fcec5b272969d6aba1/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java#L220) that creates the index depending on `config.isNullHandlingEnabled` without actually reading index configuration. That is part of the code I would like to remove in a second phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
