Jackie-Jiang commented on PR #11824: URL: https://github.com/apache/pinot/pull/11824#issuecomment-1781390155
> Not exactly. _Column level can override table level config if configured_ affects query path, not write path. At least in phase 1. In future (phase 2) we want column level to affect write path as well. > > Using your words, semantic in phase 1 is: > > * For write path (null value vector creation): > > * ON iff only enabled at table level > * For query path: > > * ON if column level is explicitly enabled > * Column level can override table level config if configured I don't quite follow then. - In the write (creation) path, we create the null value vector only when it is enabled. When column level is explicitly disabled, null vector will be disabled even though it is enabled at table level right? - In the loading path, we follow the same rule as write path - In the registering path (for multi-stage engine), we register the column as nullable only when it is explicitly enabled at column level -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
