Jackie-Jiang commented on code in PR #11824:
URL: https://github.com/apache/pinot/pull/11824#discussion_r1372380512
##########
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java:
##########
@@ -215,9 +215,18 @@ protected Object[][] provideQueries() {
public static QueryEnvironment getQueryEnvironment(int reducerPort, int
port1, int port2,
Map<String, Schema> schemaMap, Map<String, List<String>> segmentMap1,
Map<String, List<String>> segmentMap2,
@Nullable Map<String, Pair<String, List<List<String>>>>
partitionedSegmentsMap) {
+ return getQueryEnvironment(reducerPort, port1, port2, schemaMap,
segmentMap1, segmentMap2, partitionedSegmentsMap,
+ Collections.emptyMap());
+ }
+
Review Comment:
(minor) Remove extra empty line
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/nullvalue/NullValueIndexType.java:
##########
@@ -67,7 +71,7 @@ public NullValueVectorCreator
createIndexCreator(IndexCreationContext context, I
@Override
public IndexConfig getDefaultConfig() {
- return IndexConfig.DISABLED;
+ return IndexConfig.ENABLED;
Review Comment:
When is this used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
