walterddr commented on code in PR #11861:
URL: https://github.com/apache/pinot/pull/11861#discussion_r1372097031
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -392,7 +392,8 @@ public void
addFakeServerInstancesToAutoJoinHelixCluster(int numInstances, boole
public void addFakeServerInstancesToAutoJoinHelixCluster(int numInstances,
boolean isSingleTenant, int baseAdminPort)
throws Exception {
for (int i = 0; i < numInstances; i++) {
- addFakeServerInstanceToAutoJoinHelixCluster(SERVER_INSTANCE_ID_PREFIX +
i, isSingleTenant, baseAdminPort + i);
+ addFakeServerInstanceToAutoJoinHelixCluster(SERVER_INSTANCE_ID_PREFIX +
i, isSingleTenant,
+ NetUtils.findOpenPort(baseAdminPort + i));
Review Comment:
that's even worse right? if one admin port is available and one fake server
took it (but not open the port); the next server will took the +1 port as well
b/c it is still available --> that means 2 fake server will have the same admin
port ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
