walterddr commented on PR #11800:
URL: https://github.com/apache/pinot/pull/11800#issuecomment-1761810959

   > @walterddr I don't quite follow, do you mean I should change the 
values.yaml? Can you tell me where should I change?
   > 
   > I thought I should keep values.yaml unchanged, it is the person who want 
it enabled would set the following
   
   good point. first of all the endpoints should be:
   ```
   server:
   probes:
       endpoint: "/health"
       livenessEnabled: true
       livenessEndpoint: "/health?checkType=liveness"
       readinessEnabled: true
       readinessEndpoint: "/health?checkType=readiness"
   ```
   and secondly b/c health endpoint ignores unknown query parameter. it will 
work with old or new versions of pinot docker images


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to