zhtaoxiang commented on code in PR #11800:
URL: https://github.com/apache/pinot/pull/11800#discussion_r1357801716
##########
helm/pinot/templates/server/statefulset.yaml:
##########
@@ -88,15 +88,23 @@ spec:
initialDelaySeconds: {{ .Values.probes.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.periodSeconds }}
httpGet:
+ {{- if .Values.server.probes.livenessEndpoint }}
Review Comment:
two suggestions:
1. change the property to `.Values.server.livenessProbe.endpoint`
2. change line 86 to {{- if or .Values.server.probes.livenessEnabled
.Values.server.livenessProbe.endpoint }}
##########
helm/pinot/templates/server/statefulset.yaml:
##########
@@ -88,15 +88,23 @@ spec:
initialDelaySeconds: {{ .Values.probes.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.periodSeconds }}
httpGet:
+ {{- if .Values.server.probes.livenessEndpoint }}
+ path: {{ .Values.server.probes.livenessEndpoint }}
+ {{- else }}
path: {{ .Values.server.probes.endpoint }}
+ {{- end }}
port: {{ .Values.server.service.adminPort }}
{{- end }}
{{- if .Values.server.probes.readinessEnabled }}
readinessProbe:
initialDelaySeconds: {{ .Values.probes.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.periodSeconds }}
httpGet:
+ {{- if .Values.server.probes.readinessEndpoint }}
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
