alvinzhangdd opened a new pull request, #11800: URL: https://github.com/apache/pinot/pull/11800
### Change Support helm chart server separate liveness and readiness probe endpoints ### Issue https://github.com/apache/pinot/issues/11798 ### Problem Latest pinot helm chart doesn't support separate liveness and readiness probe endpoint for server ([link](https://github.com/apache/pinot/blob/master/helm/pinot/values.yaml#L311-L314)) (both use `server.probes.endpoint`) but the service underneath supports it ([link](https://github.com/apache/pinot/pull/9031)) . ### Proposal Add supports for `server.probes.livenessEndpoint` and `server.probes.readinessEndpoint` to helm chart server sts template, but make it backward compatible by falling back to the existing `server.probes.endpoint`. ### Testing Under `helm/pinot/` * `helm dependency update` * `helm install -f ./values.yaml pinot . -n pinot`. It can spin up the k8s pods locally. * Edit values.yaml Test for separate liveness and readiness probe endpoint for server. * With livenessEndpoint: "/health/liveness", readinessEndpoint: "/health/readiness" * Liveness: http-get http://:7443/health/liveness delay=120s timeout=1s period=20s #success=1 #failure=3 * Readiness: http-get http://:7443/health/readiness delay=120s timeout=1s period=20s #success=1 #failure=3 * Without * Liveness: http-get http://:7443/health delay=120s timeout=1s period=20s #success=1 #failure=3 * Readiness: http-get http://:7443/health delay=120s timeout=1s period=20s #success=1 #failure=3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
