Jackie-Jiang commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1344499584
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -318,6 +318,9 @@ public static class Broker {
"pinot.broker.enable.partition.metadata.manager";
public static final boolean DEFAULT_ENABLE_PARTITION_METADATA_MANAGER =
false;
+ public static final String CONFIG_OF_MAX_QUERY_RESPONSE_SIZE_BYTES =
"pinot.broker.max.query.response.size.bytes";
Review Comment:
Why do we have different config from instance (per query) vs from query (per
server)? IMO per server is more accurate because we don't really know the data
distribution. I'd also suggest adding the same config into the table config
(probably under query config), and the overriding sequence is query > table >
instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
