gortiz commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1343599672


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -170,15 +171,18 @@ public BaseBrokerRequestHandler(PinotConfiguration 
config, String brokerId, Brok
     _brokerTimeoutMs = config.getProperty(Broker.CONFIG_OF_BROKER_TIMEOUT_MS, 
Broker.DEFAULT_BROKER_TIMEOUT_MS);
     _queryResponseLimit =
         config.getProperty(Broker.CONFIG_OF_BROKER_QUERY_RESPONSE_LIMIT, 
Broker.DEFAULT_BROKER_QUERY_RESPONSE_LIMIT);
+    _queryMaxSerializedResponseBytes = 
config.getProperty(Broker.CONFIG_OF_MAX_QUERY_RESPONSE_SIZE_BYTES,

Review Comment:
   It can be useful to be used as a max. For example we use to start with Xmx = 
Xms, but we use the max heap value to calculate the % of heap used. We could do 
something like that with this metric.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to