vvivekiyer commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1343209381
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -362,6 +365,11 @@ public static class QueryOptionKey {
public static final String MAX_ROWS_IN_JOIN = "maxRowsInJoin";
public static final String JOIN_OVERFLOW_MODE = "joinOverflowMode";
+ // Indicates the maximum length of the serialized response per server
for a query. The response size that a
+ // server can return is allocated by dividing the total budget
CONFIG_OF_MAX_QUERY_RESPONSE_SIZE_BYTES across
+ // all servers processing the query.
+ public static final String MAX_SERIALIZED_RESPONSE_LENGTH_PER_SERVER =
"maxSerializedResponseLengthPerServer";
Review Comment:
That is correct. I've answered the reasoning in another comment above.
There's a broker instance config that defines what the maximum response size
for single query can be. If this is set, this total value is divided by the
number of routed servers to determine the per_server_budget. This
per_server_budge is set as a query config very similar to how we handle timeout
today (the alternative is to make thrift changes to pass this info).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
