gortiz commented on code in PR #11575:
URL: https://github.com/apache/pinot/pull/11575#discussion_r1327370931
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryServer.java:
##########
@@ -74,10 +80,12 @@ public QueryServer(int port, NettyConfig nettyConfig,
ChannelHandler instanceReq
* @param nettyConfig configurations for netty library
* @param tlsConfig TLS/SSL config
*/
- public QueryServer(int port, NettyConfig nettyConfig, TlsConfig tlsConfig,
ChannelHandler instanceRequestHandler) {
+ public QueryServer(int port, NettyConfig nettyConfig, TlsConfig tlsConfig,
ChannelHandler instanceRequestHandler,
+ ServerMetrics serverMetrics) {
Review Comment:
It seems ServerMetrics.get() is not accessible in QueryServer.start() in
tests. This is one of the issues of these magic static pattern. The other one
is do not forget about de-registering the static value.
It should be fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
