gortiz commented on code in PR #11575:
URL: https://github.com/apache/pinot/pull/11575#discussion_r1325576642
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java:
##########
@@ -151,7 +153,24 @@ private class ServerChannel {
ServerChannel(ServerRoutingInstance serverRoutingInstance) {
_serverRoutingInstance = serverRoutingInstance;
+ PooledByteBufAllocator bufAllocator = PooledByteBufAllocator.DEFAULT;
+ PooledByteBufAllocatorMetric metric = bufAllocator.metric();
+
_brokerMetrics.setOrUpdateGauge(BrokerGauge.NETTY_POOLED_USED_DIRECT_MEMORY.getGaugeName(),
+ metric.usedDirectMemory());
+
_brokerMetrics.setOrUpdateGauge(BrokerGauge.NETTY_POOLED_USED_HEAP_MEMORY.getGaugeName(),
Review Comment:
I think the reason we don't have that method is because local gauges (like
the ones that need table names) requires to explicitly send the table name.
Given that we use the same type for both global and local metrics, we cannot
ensure that the gauge we receive is global here.
I can add some usability methods, but I would like to make this PR as simple
as possible to merge it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
