siddharthteotia commented on PR #11575: URL: https://github.com/apache/pinot/pull/11575#issuecomment-1741305937
> But maybe what do you mean is that in some place in this PR I'm not calling the version with the supplier and therefore the value never change. It wouldn't be strange given that was my initial mistake. But I've read the PR again looking for that mistake and it looks to me that I'm always using the supplier (using the notation metric::method). Aah I see now. Yes we are on the same page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
