siddharthteotia commented on code in PR #11600:
URL: https://github.com/apache/pinot/pull/11600#discussion_r1327251147
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexType.java:
##########
@@ -226,6 +234,14 @@ public String getFileExtension(ColumnMetadata
columnMetadata) {
}
}
+ @Override
+ public List<String> getFileExtensions(@Nullable ColumnMetadata
columnMetadata) {
+ if (columnMetadata == null) {
+ return EXTENSIONS;
Review Comment:
When will this be the case (ColumnMetadata is null) ? Also since a given
column can have a single and a single kind of forward index, returning the list
of extensions isn't helpful to the caller ?
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexType.java:
##########
@@ -226,6 +234,14 @@ public String getFileExtension(ColumnMetadata
columnMetadata) {
}
}
+ @Override
+ public List<String> getFileExtensions(@Nullable ColumnMetadata
columnMetadata) {
+ if (columnMetadata == null) {
+ return EXTENSIONS;
Review Comment:
When will this be the case (`ColumnMetadata` is null) ? Also since a given
column can have a single and a single kind of forward index, returning the list
of extensions isn't helpful to the caller ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
