gortiz commented on code in PR #11600: URL: https://github.com/apache/pinot/pull/11600#discussion_r1327250128
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/text/TextIndexType.java: ########## @@ -70,6 +71,11 @@ public class TextIndexType extends AbstractIndexType<TextIndexConfig, TextIndexR protected static final Logger LOGGER = LoggerFactory.getLogger(TextIndexType.class); public static final String INDEX_DISPLAY_NAME = "text"; + // TODO: Should V1Constants.Indexes.LUCENE_TEXT_INDEX_DOCID_MAPPING_FILE_EXTENSION be added here? Review Comment: > It is a mapping file we maintain to map Lucene internal docID to pinot segment docID as the former is not guaranteed to be the same as our representation. That means that a text file may require to have not one but two files? If that is the case, we would need to adapt the code a bit more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
