gortiz commented on code in PR #11600: URL: https://github.com/apache/pinot/pull/11600#discussion_r1327248444
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/text/TextIndexType.java: ########## @@ -70,6 +71,11 @@ public class TextIndexType extends AbstractIndexType<TextIndexConfig, TextIndexR protected static final Logger LOGGER = LoggerFactory.getLogger(TextIndexType.class); public static final String INDEX_DISPLAY_NAME = "text"; + // TODO: Should V1Constants.Indexes.LUCENE_TEXT_INDEX_DOCID_MAPPING_FILE_EXTENSION be added here? Review Comment: But we use `getFileExtensions` to know if a column is indexed or not by that index. I guess I should reformulate the question as: having a file with `LUCENE_TEXT_INDEX_DOCID_MAPPING_FILE_EXTENSION` means we actually have an index of type text or is it some intermediate file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
