siddharthteotia commented on code in PR #11575:
URL: https://github.com/apache/pinot/pull/11575#discussion_r1323343206
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -46,6 +47,26 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
DEDUP_PRIMARY_KEYS_COUNT("dedupPrimaryKeysCount", false),
CONSUMPTION_QUOTA_UTILIZATION("ratio", false),
JVM_HEAP_USED_BYTES("bytes", true),
+ NETTY_POOLED_USED_DIRECT_MEMORY("bytes", true),
+ NETTY_POOLED_USED_HEAP_MEMORY("bytes", true),
+ NETTY_POOLED_ARENAS_DIRECT("arenas", true),
+ NETTY_POOLED_ARENAS_HEAP("arenas", true),
Review Comment:
Seems like we are emitting only once. Shouldn't at least the first two be
emitted like other metrics to observe the trend in steady state as system is
serving queries ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
