wirybeaver commented on code in PR #10815:
URL: https://github.com/apache/pinot/pull/10815#discussion_r1295489950


##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -706,6 +710,8 @@ protected List<PeriodicTask> setupControllerPeriodicTasks() 
{
         new TaskMetricsEmitter(_helixResourceManager, 
_helixTaskResourceManager, _leadControllerManager, _config,
             _controllerMetrics);
     periodicTasks.add(_taskMetricsEmitter);
+    _realtimeTempSegmentCleaner = new RealtimeTempSegmentCleaner(_config, 
_helixResourceManager, _leadControllerManager,
+        _pinotLLCRealtimeSegmentManager, _validationMetrics, 
_controllerMetrics);

Review Comment:
   deleting tmp segments will be invoked with the existing realtime segment 
validation manager



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to