[GitHub] [pinot] wirybeaver commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

[via GitHub]

wirybeaver commented on code in PR #10815:
URL: https://github.com/apache/pinot/pull/10815#discussion_r1262807636


##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -239,6 +239,14 @@ public void cleanupSegmentCountGauge(final String 
resource) {
     removeGauge(resource, ValidationMetricName.SEGMENT_COUNT);
   }
 
+  public void updateTmpSegCountGauge(final String resource, final long 
tmpSegmentCount) {
+    makeGauge(resource, ValidationMetricName.DELETED_TMP_SEGMENT_COUNT, 
_storedValueGaugeFactory, tmpSegmentCount);
+  }
+
+  public void cleanupTmpSegCountGauge(final String resource) {
+    removeGauge(resource, ValidationMetricName.SEGMENT_COUNT);

Review Comment:
   yeah



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org