[GitHub] [pinot] wirybeaver commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

[via GitHub]

wirybeaver commented on code in PR #10815:
URL: https://github.com/apache/pinot/pull/10815#discussion_r1262806830


##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -215,9 +219,14 @@ public static class ControllerPeriodicTasksConf {
         "controller.realtime.segment.deepStoreUploadRetryEnabled";
     public static final String DEEP_STORE_RETRY_UPLOAD_TIMEOUT_MS =
         "controller.realtime.segment.deepStoreUploadRetry.timeoutMs";
+    public static final String ENABLE_TMP_SEGMENT_ASYNC_DELETION =
+        "controller.realtime.split.commit.segment.tmp.cleanup.async.enable";

Review Comment:
   Actually, the skip logic is inside the task. Since it's a little bit 
complicated, I wanted to encapsulate the logic inside task instead of expose it 
on starter.
   
   ```
       if (!isLowLevelConsumer(tableNameWithType, tableConfig)
           || !getIsSplitCommitEnabled()
           || !isTmpSegmentAsyncDeletionEnabled()) {
         return 0L;
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org