Jackie-Jiang commented on code in PR #11017:
URL: https://github.com/apache/pinot/pull/11017#discussion_r1281456311
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfig.java:
##########
@@ -223,6 +212,17 @@ public StreamConfig(String tableNameWithType, Map<String,
String> streamConfigMa
_streamConfigMap.putAll(streamConfigMap);
}
+ public static void validateConsumerType(String streamType, Map<String,
String> streamConfigMap) {
+ String consumerTypesKey =
+ StreamConfigProperties.constructStreamProperty(streamType,
StreamConfigProperties.STREAM_CONSUMER_TYPES);
+ String consumerTypes = streamConfigMap.get(consumerTypesKey);
+ Preconditions.checkNotNull(consumerTypes, consumerTypesKey + " cannot be
null");
+ for (String consumerType : consumerTypes.split(",")) {
+
Preconditions.checkState(ConsumerType.LOWLEVEL.name().equalsIgnoreCase(consumerType)
+ || SIMPLE_CONSUMER_TYPE_STRING.equalsIgnoreCase(consumerType),
Review Comment:
Ah, sorry I misread it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
