Jackie-Jiang commented on code in PR #11017:
URL: https://github.com/apache/pinot/pull/11017#discussion_r1274221321
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfig.java:
##########
@@ -126,6 +126,7 @@ public StreamConfig(String tableNameWithType, Map<String,
String> streamConfigMa
String consumerFactoryClassKey =
StreamConfigProperties.constructStreamProperty(_type,
StreamConfigProperties.STREAM_CONSUMER_FACTORY_CLASS);
// For backward compatibility, default consumer factory is for Kafka.
+ // TODO: remove this default and make it mandatory to have a factory class
Review Comment:
IMO it is okay to use Kafka by default, as long as we document it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
