navina commented on code in PR #11017:
URL: https://github.com/apache/pinot/pull/11017#discussion_r1281431147
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -502,6 +495,24 @@ protected void configure() {
LOGGER.info("Starting controller admin application on: {}",
ListenerConfigUtil.toString(_listenerConfigs));
_adminApp.start(_listenerConfigs);
+ List<String> existingHlcTables = new ArrayList<>();
+ _helixResourceManager.getAllRealtimeTables().forEach(rt -> {
+ TableConfig tableConfig = _helixResourceManager.getTableConfig(rt);
+ if (tableConfig != null) {
+ Map<String, String> streamConfigMap =
IngestionConfigUtils.getStreamConfigMap(tableConfig);
+ try {
+ StreamConfig.validateConsumerType(
+ streamConfigMap.getOrDefault(StreamConfigProperties.STREAM_TYPE,
"kafka"), streamConfigMap);
Review Comment:
yeah I don't want to change it in this PR. Might break more tests. Also, if
the default was assumed to be "kafka" before, then existing llc tables might
also end-up breaking due to the mandatory stream type check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
