klsince commented on code in PR #11020:
URL: https://github.com/apache/pinot/pull/11020#discussion_r1250183518


##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -135,6 +136,11 @@ public synchronized void init(PinotConfiguration config, 
HelixManager helixManag
     // used to initialize a segment refresh semaphore to limit the 
parallelism, so create a pool of same size.
     _segmentRefreshExecutor = 
Executors.newFixedThreadPool(getMaxParallelRefreshThreads(),
         new 
ThreadFactoryBuilder().setNameFormat("segment-refresh-thread-%d").build());
+    LOGGER.info("Initialized segment refresh executor thread pool: {}", 
getMaxParallelRefreshThreads());
+    _segmentPreloadExecutor = 
Executors.newFixedThreadPool(_instanceDataManagerConfig.getMaxSegmentPreloadThreads(),

Review Comment:
   sgtm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to