somandal commented on code in PR #10846:
URL: https://github.com/apache/pinot/pull/10846#discussion_r1248289636
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/function/InternalReduceFunctions.java:
##########
@@ -35,17 +33,10 @@ private InternalReduceFunctions() {
}
@ScalarFunction
- public static double skewnessReduce(PinotFourthMoment fourthMoment) {
- return fourthMoment.skew();
- }
-
- @ScalarFunction
- public static double kurtosisReduce(PinotFourthMoment fourthMoment) {
- return fourthMoment.kurtosis();
- }
-
- @ScalarFunction
- public static int countDistinctReduce(Set<?> values) {
- return values.size();
+ public static Double avgReduce(Double intermediateResultSum, Long
intermediateResultCount) {
Review Comment:
done
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/hint/PinotHintStrategyTable.java:
##########
@@ -27,8 +27,11 @@
* Default hint strategy set for Pinot query.
*/
public class PinotHintStrategyTable {
- public static final String INTERNAL_AGG_INTERMEDIATE_STAGE =
"aggIntermediateStage";
public static final String INTERNAL_AGG_FINAL_STAGE = "aggFinalStage";
+ public static final String INTERNAL_AGG_INTERMEDIATE_STAGE =
"aggIntermediateStage";
+ public static final String INTERNAL_AGG_LEAF_STAGE = "aggLeafStage";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
