kishoreg commented on code in PR #10846:
URL: https://github.com/apache/pinot/pull/10846#discussion_r1219852675
##########
pinot-query-planner/src/main/java/org/apache/calcite/sql/fun/PinotOperatorTable.java:
##########
@@ -103,6 +98,61 @@ public final void initNoDuplicate() {
throw Util.throwAsRuntime(Util.causeOrSelf(e));
}
}
+
+ // Walk through all the Pinot aggregation types and register those that
are supported in multistage and which
+ // aren't standard Calcite functions such as SUM / MIN / MAX / COUNT etc.
+ for (AggregationFunctionType aggregationFunctionType :
AggregationFunctionType.values()) {
+ if (aggregationFunctionType.isNativeCalciteAggregationFunctionType()
+ || !aggregationFunctionType.isSupportedInMultiStage()) {
Review Comment:
then have a negation list to list the ones that are not supported in v2 or
something calcite already supports.. my concern is that the aggregationfunction
type itself should not care about its supported in multistage etc..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
