navina commented on code in PR #10703:
URL: https://github.com/apache/pinot/pull/10703#discussion_r1235954709
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -220,11 +255,19 @@ protected void doAddRecord(MutableSegment segment,
RecordInfo recordInfo) {
protected GenericRow doUpdateRecord(GenericRow record, RecordInfo
recordInfo) {
Review Comment:
> When the new record is a delete record, we can skip reading the previous
record and updating the new record.
Ah, I think it should still merge with previous record because technically,
you could view it as just another update to the delete column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
