navina commented on code in PR #10703:
URL: https://github.com/apache/pinot/pull/10703#discussion_r1235929422
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java:
##########
@@ -388,6 +388,12 @@ public List<String> getUpsertComparisonColumns() {
return _upsertConfig == null ? null : _upsertConfig.getComparisonColumns();
}
+ @JsonIgnore
+ @Nullable
+ public String getUpsertDeleteRecordColumn() {
Review Comment:
huh.. even I prefer `deleteRecordColumn`. Will fix the ones that deviated
from this name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
