navina commented on code in PR #10703:
URL: https://github.com/apache/pinot/pull/10703#discussion_r1235918642
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -409,7 +416,62 @@ protected TableConfig createUpsertTableConfig(File
sampleAvroFile, String primar
.setRoutingConfig(new RoutingConfig(null, null,
RoutingConfig.STRICT_REPLICA_GROUP_INSTANCE_SELECTOR_TYPE))
.setSegmentPartitionConfig(new
SegmentPartitionConfig(columnPartitionConfigMap))
.setReplicaGroupStrategyConfig(new
ReplicaGroupStrategyConfig(primaryKeyColumn, 1))
- .setUpsertConfig(new UpsertConfig(UpsertConfig.Mode.FULL)).build();
+ .setUpsertConfig(upsertConfig).build();
+ }
+
+
+ protected Map<String, String> getCSVStreamConfigMap(@Nullable String
delimiter, @Nullable String csvHeaderProperty) {
Review Comment:
Yeah. this is just the decoder properties. Renaming the method
appropriately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
