egalpin commented on code in PR #10704:
URL: https://github.com/apache/pinot/pull/10704#discussion_r1204816820
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ComparisonColumns.java:
##########
@@ -37,10 +38,45 @@ public int getComparableIndex() {
return _comparableIndex;
}
+ public int compareToSealed(ComparisonColumns other) {
+ /*
+ - iterate over all columns
+ - if any value in _values is greater than its counterpart in
_other._values, keep _values as-is and return 1
+ - if any value in _values is less than its counterpart in
_other._values _and_ none are greater than their
+ counterpart in _other._values, keep _values as-is and return -1
+ - i.e. no value in _this_ is greater than its counterpart in _other
Review Comment:
The original goal was to ensure that a default value like Long.MIN_VALUE
stored for a comparison column would not cause accidental rejection of data.
But in looking at this again after some time, I agree with your assessment that
it seems sufficient to simply return if any value is less that its counterpart.
If the values were both null i.e. default value, the `compareTo` would return
`0` so that case would be handled without issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
