egalpin commented on PR #10704: URL: https://github.com/apache/pinot/pull/10704#issuecomment-1532199044
> So the fix should be: when comparisonIndex is -1, loop over all values and check if it has any value larger than the value in another ComparisonColumns. There is no need to modify the value within the current ComparisonColumns because it should already have values set. One case I'm struggling to figure out how to support is when altering from one set of comparison columns to a new set. In such a case, I believe there would be a need to modify the value within the current ComparisonColumns (ex. adding 1 new column in addition to a set of existing comparison columns, or migrating from a single comparison column to a set of columns). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
