egalpin commented on code in PR #10704:
URL: https://github.com/apache/pinot/pull/10704#discussion_r1187762408
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertUtils.java:
##########
@@ -190,13 +191,14 @@ public Comparable getComparisonValue(int docId) {
for (int i = 0; i < _comparisonColumnReaders.length; i++) {
PinotSegmentColumnReader columnReader = _comparisonColumnReaders[i];
- Comparable comparisonValue = (Comparable)
UpsertUtils.getValue(columnReader, docId);
+ Comparable comparisonValue = null;
+ if (!columnReader.isNull(docId)) {
Review Comment:
I'm not sure if having this null-check is actually useful. I think the
logic within ComparisonColumns would stay the same regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
