walterddr commented on code in PR #10779:
URL: https://github.com/apache/pinot/pull/10779#discussion_r1198026292
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestUtils.java:
##########
@@ -291,4 +169,106 @@ private static void attachTimeBoundary(PinotQuery
pinotQuery, TimeBoundaryInfo t
pinotQuery.setFilterExpression(timeFilterExpression);
}
}
+
+ /**
+ * attach the dynamic filter to the given PinotQuery.
+ */
+ static void attachDynamicFilter(PinotQuery pinotQuery, JoinNode.JoinKeys
joinKeys, List<Object[]> dataContainer,
+ DataSchema dataSchema) {
Review Comment:
TODO: handle
1. empty dataContainer,
2. empty existing filter
3. null dataContainer or errored dataContainer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
